Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up how we log + time #82

Open
jonkeane opened this issue Sep 19, 2022 · 2 comments
Open

Clean up how we log + time #82

jonkeane opened this issue Sep 19, 2022 · 2 comments

Comments

@jonkeane
Copy link
Contributor

We currently do a few hand-coded timing of steps. But maybe we should be more systematic and make a timing helper that we can use to "just" wrap specific functions (rather than starting a timer then stopping at the top|bottom of each)

@joosthooz
Copy link
Collaborator

The timing code is a relic from back when we were still experimenting and comparing performance, we could also just remove it.

@jonkeane
Copy link
Contributor Author

Yeah, removing it is fine too, I guess really we would want to truly profile code like that when experimenting with speedups (e.g. confirming that our partitioning in dbgen works well, when we tackle tpc-ds, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants