Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate dim after conversion, fill in dim in fill_metadata_from_files #98

Open
joosthooz opened this issue Sep 27, 2022 · 0 comments
Open

Comments

@joosthooz
Copy link
Collaborator

The code in Dataset.convert() that carries on dim from the old tables into the new is a bit ugly (although it does prevent having to probe the full dataset to count the nr of rows, instead taking nrows from the dim metadata), and currently there is no validation the dims didn't change during the conversion (that should trigger an error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant