Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution request: Dockerfile base_image ARG #115

Open
jameshochadel opened this issue Aug 8, 2023 · 0 comments
Open

Contribution request: Dockerfile base_image ARG #115

jameshochadel opened this issue Aug 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jameshochadel
Copy link

Is your feature request related to a problem? Please describe.

My team would like to use the oci-build-task, but we must only run container images that are built on a hardened base image in our environment. The Dockerfile uses a hardcoded base image, so we cannot use the images built upstream or build an image from the Dockerfile ourselves without modifications.

Describe the solution you'd like

Several resources maintained by Concourse, such as the registry-image-resource, parameterize the base image in their Dockerfiles using a build arg. For example: https://github.com/concourse/registry-image-resource/blob/13bcb3c09c71580d69d46d236d69d0669f9c2b6f/Dockerfile#L1

I propose changing the Dockerfile in oci-build-task to use the same approach. I am willing to submit a PR to make this change, but I wanted to propose it first. I am not sure if there are different considerations for a task in general vs a resource, or for this task in particular.

Describe alternatives you've considered

Without the base image passed as an argument, our team will need to fork the oci-build-task and maintain a modified Dockerfile. Since we've been able to build several concourse/*-resource images directly using their parameterized Dockerfiles, I hope we can do the same with this task.

Additional context

No response

@jameshochadel jameshochadel added the enhancement New feature or request label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant