Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjpeg-turbo and jpeg clobbering each other #133

Closed
h-vetinari opened this issue Jan 9, 2023 · 8 comments · Fixed by #137
Closed

libjpeg-turbo and jpeg clobbering each other #133

h-vetinari opened this issue Jan 9, 2023 · 8 comments · Fixed by #137

Comments

@h-vetinari
Copy link
Member

From discussion in #126:

@ocefpaf: We need an ecosystem wide migration to drop jpeg in lieu of libjeg-turbo to merge #128. While that is, IMO the best path we cannot merge that right now until we start the migration.

@h-vetinari: You do realise that you merged the libjpeg-turbo version in #132?

@ocefpaf: Yep. Kind of wanted to give it a go after thinking about it. I believe we can start updating the feedstocks without a migration.

From #132:

This does not seem to be working as expected:

ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::jpeg-9e-h8ffe710_2, conda-forge/win-64::libjpeg-turbo-2.1.4-hcfcfb64_0
  path: 'library/include/jpeglib.h'


ClobberWarning: This transaction has incompatible packages due to a shared path.
  packages: conda-forge/win-64::jpeg-9e-h8ffe710_2, conda-forge/win-64::libjpeg-turbo-2.1.4-hcfcfb64_0
  path: 'library/lib/jpeg.lib'

(Seen in conda-forge/gymnasium-feedstock#9)

Originally posted by @h-vetinari in #132 (comment)

@hmaarrfk
Copy link
Contributor

yeah, we have a libjpeg turbo mapped out, just nobody had time to go through it. can we revert the use of libjpeg turbo here?

@hmaarrfk
Copy link
Contributor

@h-vetinari
Copy link
Member Author

h-vetinari commented Jan 20, 2023

@ocefpaf decided to merge #132 after thinking about it (see thread starting here). I don't mind what we do either way.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 20, 2023

We probably need to full migration. Hopefully this will be the trigger for us to discuss this. We should phase out the jpeg library and move to the better maintained libjpeg-turbo.

@jakirkham
Copy link
Member

Can we do something like blas?

Recall this was complicated before because of version compatibility/feature support, but am hoping that gap has closed over time to make this easier

@hmaarrfk
Copy link
Contributor

Can we discuss in conda-forge/conda-forge.github.io#673 (comment)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 1, 2023

as a Pillow specific question, can today's pillow be built with standard jpeg (i.e. not libjpeg-turbo)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Feb 1, 2023

I somewhat see this move to using jpeg turbo has counter to the open discussion we had referenced above.

I think it would be good if we reverted the merge with turbo, see #134, and made pillow depend on jpeg instead until the conversation at conda-forge/conda-forge.github.io#673 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants