Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry 1.2.0 #70

Closed
drhagen opened this issue Aug 30, 2022 · 20 comments
Closed

Poetry 1.2.0 #70

drhagen opened this issue Aug 30, 2022 · 20 comments
Labels
question Further information is requested

Comments

@drhagen
Copy link

drhagen commented Aug 30, 2022

Comment:

Poetry has released 1.2.0rc2 and is going to finalize 1.2.0 soon. Can I request a cut of the latest release candidate so that I can test how downstream conda dependencies work under 1.2?

@drhagen drhagen added the question Further information is requested label Aug 30, 2022
@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

We've been having real trouble with circular dependencies between poetry and poetry-plugin-export: python-poetry/poetry#5980

Since that issue is still open, I had assumed that wasn't resolved. conda really cannot handle circular dependencies at all so I don't think we have a workaround for this.

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

I'll go through the process, though, and see what we find with the latest RCs.

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

I'm building 1.2.0rc2 but also with a patch from python-poetry/poetry#5980. That's our only way forward here.

@drhagen
Copy link
Author

drhagen commented Aug 30, 2022

I'm building 1.2.0rc2 but also with a patch from python-poetry/poetry#5980. That's our only way forward here.

I support this. I would rather a release of Poetry 1.2 with the deprecated export function removed than no Poetry 1.2 at all.

@maresb
Copy link
Contributor

maresb commented Aug 30, 2022

This seems fairly dangerous to me. Do we really want a conda-forge version of Poetry which diverges from the standard one? How confident are we that leaving out the export plugin dependency won't lead to ImportErrors?

@maresb maresb mentioned this issue Aug 30, 2022
4 tasks
@maresb
Copy link
Contributor

maresb commented Aug 30, 2022

If the Poetry devs believe this is too big of a change and not suitable for 1.2, shouldn't we listen to them?

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

So I think the bigger problem is if we simply can't build a package for poetry >=1.2.0 at all. At least this is a way forward. My understanding. But it seems like downsteam users need both poetry and poetry-plugin-export so breaking them into 2 packages was probably not a good move. That's what I'm gathering from the discussion in any case.

@maresb
Copy link
Contributor

maresb commented Aug 30, 2022

Ya, this seems like a pretty terrible situation.

Another horrible but potentially safer hack would be to make a special copy of poetry-plugin-export which doesn't depend on Poetry. Perhaps poetry-plugin-export-deprecated? And then you make poetry depend on that until poetry straightens things out.

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

I could see how that would "work" better downstream in that installing poetry would get the poetry-plugin-export features. But it's a pretty giant mess.

@maresb
Copy link
Contributor

maresb commented Aug 30, 2022

On a compleeeetely unrelated side note, I must report that I'm very pleased so far with Hatch. 😄

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

Not something I've tried.

@drhagen
Copy link
Author

drhagen commented Aug 30, 2022

But it seems like downsteam users need both poetry and poetry-plugin-export so breaking them into 2 packages was probably not a good move.

Breaking functionality out into an optional package is pretty common and normal. The original sin was pulling out the functionality before being truly ready to make the functionality optional.

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

@drhagen, thanks for the insight. I'm not particularly expert in the specific of poetry or its history.

@xylar
Copy link
Contributor

xylar commented Aug 30, 2022

But I agree, breaking out packages that are optional dependencies (or shared ones) is very handy indeed!

@maresb
Copy link
Contributor

maresb commented Aug 30, 2022

And that happens to be exactly Hatch's philosophy. Standards-based and highly extensible. It even supports Conda environments, though I haven't played with that plugin yet.

@xylar xylar mentioned this issue Aug 31, 2022
3 tasks
@xylar
Copy link
Contributor

xylar commented Aug 31, 2022

As I commented on #72, another problem keeping us from releasing is that there hasn't been a release of cleo 1.0.0.

@maresb
Copy link
Contributor

maresb commented Aug 31, 2022

Haha, hi @ofek! Wasn't expecting to see you here with the 👍. (He's the Hatch maintainer, and is very responsive.)

mbargull added a commit to regro-cf-autotick-bot/poetry-plugin-export-feedstock that referenced this issue Oct 30, 2022
@mbargull
Copy link
Member

mbargull commented Oct 30, 2022

I've added a suggestion for a workaround for the current dependency cycle at conda-forge/poetry-plugin-export-feedstock#8 (comment) .

@xylar
Copy link
Contributor

xylar commented Nov 22, 2022

It seems poetry is not yet compatible with cleo 2.0.0, which was just released. We need to keep an eye on python-poetry/poetry#7070 and wait for a new release (or patch?).

@xylar xylar mentioned this issue Nov 22, 2022
3 tasks
@maresb
Copy link
Contributor

maresb commented Dec 11, 2022

While we skipped v1.2, we now have a v1.3 release.

@maresb maresb closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants