-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect RPC import path being the Buf-tour path #736
Comments
@sudowoodo200 |
Yup here you go:
|
The issue seems to be caused by not specifying the go_package option. option go_package = "{module_name}/go/pkgs/bindings/proto/v1;foov1"; |
@sudowoodo200, this configuration looks incomplete. As @hirasawayuki points out, the proto has no Go package option. And the Also, you don't actually state what you were expecting as the import path. What is the intent? Why is the generated import "totally wrong"? |
@jhump , @hirasawayuki -- extremely helpful, thank you! Both are bona fide omissions. Let me go try it. I simply ported over the code that I used for grpc-go and was taken aback by the buf-tour import. Update: Solved! My bad, sorry guys! |
Describe the bug
.connect.go
file imports.pb.go
file asv1 "github.com/bufbuild/buf-tour/gen/v1"
. Totally wrong. I believe it's because my proto directory has "v1"To Reproduce
buf.gen.yaml
command
buf generate --path ./v1/*.proto
Results:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: