-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build InstructLab RHEL AI container images #364
Comments
Looking for acceptance criteria from @rhatdan and @sallyom. Many people have asks but no one has be able to clarify what the actual requirements are. From my understanding it would be something along the following lines
|
Instructlab+RHEL AI based images get in. |
This has been addressed in a number of PRs that landed in main, but this successful action run shows that images are landing in quay.io. |
This does work however it only tests 2 of the 3 images we want. We also want the intel based one. Therefore I will refactor this to use the make targets, tracked in #384 |
@rhatdan Would you please map the images you have listed here with the ones listed in the Makefile. Which ones should be built by the end of this week? |
@Gregory-Pereira Isn't #384 somewhat a duplication of this issue? What would be different in the acceptance criteria from this issue? |
@Gregory-Pereira I'm aware that I'm nit picking. For the sake of the board hygiene let's carefully review the acceptance criteria this ticket has and create a new issue for outcomes which are not covered by the existing one. |
As far as I can tell, at this point all 3 of our acceptance criteria have been met, but waiting for tomorrow for images to land to say for sure.
If our images show up tomorrow and I can check this box, im closing this issue |
Build the images listed in the following Makefile - https://github.com/containers/ai-lab-recipes/blob/main/training/instructlab/Makefile
Acceptance Criteria:
The text was updated successfully, but these errors were encountered: