Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build InstructLab RHEL AI container images #364

Open
lmilbaum opened this issue Apr 29, 2024 · 9 comments
Open

Build InstructLab RHEL AI container images #364

lmilbaum opened this issue Apr 29, 2024 · 9 comments
Assignees
Labels

Comments

@lmilbaum
Copy link
Collaborator

lmilbaum commented Apr 29, 2024

Build the images listed in the following Makefile - https://github.com/containers/ai-lab-recipes/blob/main/training/instructlab/Makefile
Acceptance Criteria:

  1. The images are built and pushed to quay.io/ai-lab once a day
  2. They are built with automation. Preferably with GitHub Actions workflow.
  3. All images are amd only. Multi-arch is NOT required at the moment.
@lmilbaum lmilbaum self-assigned this Apr 29, 2024
@Gregory-Pereira
Copy link
Collaborator

Looking for acceptance criteria from @rhatdan and @sallyom. Many people have asks but no one has be able to clarify what the actual requirements are. From my understanding it would be something along the following lines

  • Instructlab images get build and land in quay.io/ai-lab everyday
  • Images are multi-arch

@lmilbaum lmilbaum added the CI/CD label Apr 29, 2024
@rhatdan
Copy link
Member

rhatdan commented Apr 29, 2024

Instructlab+RHEL AI based images get in.

@Gregory-Pereira
Copy link
Collaborator

This has been addressed in a number of PRs that landed in main, but this successful action run shows that images are landing in quay.io.

@Gregory-Pereira
Copy link
Collaborator

Gregory-Pereira commented Apr 29, 2024

This does work however it only tests 2 of the 3 images we want. We also want the intel based one. Therefore I will refactor this to use the make targets, tracked in #384

@lmilbaum
Copy link
Collaborator Author

Instructlab+RHEL AI based images get in.

@rhatdan Would you please map the images you have listed here with the ones listed in the Makefile. Which ones should be built by the end of this week?

@lmilbaum
Copy link
Collaborator Author

lmilbaum commented Apr 29, 2024

@Gregory-Pereira Isn't #384 somewhat a duplication of this issue? What would be different in the acceptance criteria from this issue?

@Gregory-Pereira
Copy link
Collaborator

my understanding was that #364 (this issue) tracks all the acceptance criteria and everything that needs to get done before summit for CI/CD and #384 was just tracking the 1 refactor from building from buildah to using make targets

@lmilbaum
Copy link
Collaborator Author

@Gregory-Pereira I'm aware that I'm nit picking. For the sake of the board hygiene let's carefully review the acceptance criteria this ticket has and create a new issue for outcomes which are not covered by the existing one.
Implementation details could be shared in this issue. Does that make sense?

@Gregory-Pereira
Copy link
Collaborator

Gregory-Pereira commented Apr 30, 2024

As far as I can tell, at this point all 3 of our acceptance criteria have been met, but waiting for tomorrow for images to land to say for sure.

  • The images are built and pushed to quay.io/ai-lab once a day (should be done but confirming tomorrow)
  • They are built with automation. Preferably with GitHub Actions workflow.
  • All images are amd only. Multi-arch is NOT required at the moment.

If our images show up tomorrow and I can check this box, im closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

3 participants