Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for filesystem types for non-root partitions #499

Open
achilleas-k opened this issue Apr 29, 2024 · 2 comments
Open

Support for filesystem types for non-root partitions #499

achilleas-k opened this issue Apr 29, 2024 · 2 comments
Labels
area/install Issues related to `bootc install`

Comments

@achilleas-k
Copy link

Related to osbuild/bootc-image-builder#407:
I was curious if there are plans to support defining the filesystem for partitions other than root (specifically /boot). Currently, the way BIB works, we have a situation where users can control the filesystem type of their root partition, but have no control over /boot and it creates a mismatch which, while not invalid, can be a bit unusual.

If not, if we don't want to overcomplicate the bootc install configuration, I think it might be more appropriate to have pre-defined partitioning schemes that control multiple partitions (similar to Anaconda kickstart's autopart).

@cgwalters cgwalters added the area/install Issues related to `bootc install` label Apr 29, 2024
@cgwalters
Copy link
Collaborator

I think actually I'd vote to drop the separate /boot partition by default just to keep things extra simple.

The reason it's there is because it's necessary for LUKS cases, but that's it's own thread around supporting...and all of this heavily intersects with something like #440 which would come at this from an entirely different way.

Tangentially related to this systemd/uapi recently started suggesting that /boot aka xbootldr is FAT32 as well like the ESP. It simplifies things mainly for systemd-boot (i.e. not grub, which already has the filesystem drivers and is really its own mini-OS).

But anyways my thinking here has leaned a lot closer to the idea in #440 that we streamline having downstream OS containers provide their own partitioning logic, just hooked "underneath" bootc install to at least have some common interfaces.

cgwalters added a commit to cgwalters/bootc that referenced this issue May 14, 2024
In order to simplify what we're doing here, let's drop the separate
`/boot` aka XBOOTLDR partition by default for the `to-disk --block-setup=direct`
path (the default).

We retain it when using `--block-setup=tpm2-luks` as it's required there.

Notably this kills off a hardcoded "ext4 for /boot" which is suboptimal
for many reasons.

Longer term again I'd like to emphasize `install to-filesystem` with
external installers, plus integrating external installation scripts
as part of `bootc install to-disk`.

xref:
- containers#499
- containers#440
@cgwalters
Copy link
Collaborator

I did #529 which is related to this.

cgwalters added a commit to cgwalters/bootc that referenced this issue May 14, 2024
In order to simplify what we're doing here, let's drop the separate
`/boot` aka XBOOTLDR partition by default for the `to-disk --block-setup=direct`
path (the default).

We retain it when using `--block-setup=tpm2-luks` as it's required there.

Notably this kills off a hardcoded "ext4 for /boot" which is suboptimal
for many reasons.

Longer term again I'd like to emphasize `install to-filesystem` with
external installers, plus integrating external installation scripts
as part of `bootc install to-disk`.

xref:
- containers#499
- containers#440

Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters added a commit to cgwalters/bootc that referenced this issue May 15, 2024
In order to simplify what we're doing here, let's drop the separate
`/boot` aka XBOOTLDR partition by default for the `to-disk --block-setup=direct`
path (the default).

We retain it when using `--block-setup=tpm2-luks` as it's required there.

Notably this kills off a hardcoded "ext4 for /boot" which is suboptimal
for many reasons.

Longer term again I'd like to emphasize `install to-filesystem` with
external installers, plus integrating external installation scripts
as part of `bootc install to-disk`.

xref:
- containers#499
- containers#440

Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

No branches or pull requests

2 participants