Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not ignore SIGWINCH if no terminal is allocated #1442

Open
waldiTM opened this issue Mar 31, 2024 · 0 comments
Open

Does not ignore SIGWINCH if no terminal is allocated #1442

waldiTM opened this issue Mar 31, 2024 · 0 comments

Comments

@waldiTM
Copy link

waldiTM commented Mar 31, 2024

In src/libcrun/container.c exists a handler for SIGWINCH. This handler breaks out of the wait loop prematurely if no terminal is assigned:

                  if (UNLIKELY (args->terminal_fd < 0))
                    return 0;

As SIGWINCH can be sent at any time, this causes the whole container to be killed of if the terminal the crun process runs in is resized. As this signal is not critical, all failures in this handler should be ignored and not lead to killed containers.

@waldiTM waldiTM changed the title Does not ignore SIGWINCH if not terminal is allocated Does not ignore SIGWINCH if no terminal is allocated Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant