Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart chatbot is notifying about git HEAD #1081

Open
benoitf opened this issue May 13, 2024 · 8 comments
Open

restart chatbot is notifying about git HEAD #1081

benoitf opened this issue May 13, 2024 · 8 comments
Assignees

Comments

@benoitf
Copy link
Collaborator

benoitf commented May 13, 2024

Is your enhancement related to a problem? Please describe

when restarting the chatbot app we're notified that the GitHub head is different than v1.1.1

image

Describe the solution you'd like

no notification, just restart as I'm using the tag and I didn't change the app

Describe alternatives you've considered

No response

Additional context

No response

@axel7083
Copy link
Contributor

axel7083 commented May 27, 2024

Facing the same issue since we are using the git node implementation

cc @feloy

@feloy
Copy link
Contributor

feloy commented Jun 5, 2024

I cannot reproduce the problem on my machines (mac and Linux).

Could you please share some information of the state of the chatbot repository, by running the commands below?

$ cat .git/HEAD 
70c990bc21c70a145e46edd9cf84738d3607ecc1

$ cat .git/refs/tags/v1.1.2 
70c990bc21c70a145e46edd9cf84738d3607ecc1

@axel7083
Copy link
Contributor

axel7083 commented Jun 5, 2024

Here is a video demonstration of the problem I have on my computer, which is not the same as @benoitf but still linked to the git logic.

  • Start without chatbot cloned.
  • Latest main cloned and build
long-git-error-reproductible.mp4
$ cat .git/refs/tags/v1.1.2
70c990bc21c70a145e46edd9cf84738d3607ecc1
$ cat .git/HEAD
70c990bc21c70a145e46edd9cf84738d3607ecc1
$ git status
Not currently on any branch.
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        deleted:    recipes/common/usr/lib/systemd/system/local-fs.target.wants/bootc-generic-growpart.service
        deleted:    recipes/natural_language_processing/chatbot/quadlet/chatbot.image
        deleted:    recipes/natural_language_processing/codegen/quadlet/codegen.image
        deleted:    recipes/natural_language_processing/rag/quadlet/rag.image
        deleted:    recipes/natural_language_processing/summarizer/quadlet/summarizer.image
        deleted:    training/common/usr/lib/systemd/system/local-fs.target.wants/bootc-generic-growpart.service

@benoitf
Copy link
Collaborator Author

benoitf commented Jun 5, 2024

I don't remember how I ran into this bug :-/

@jeffmaury jeffmaury assigned jeffmaury and unassigned feloy Jun 5, 2024
@feloy
Copy link
Contributor

feloy commented Jun 5, 2024

Here is a video demonstration of the problem I have on my computer, which is not the same as @benoitf but still linked to the git logic.

  • Start without chatbot cloned.
  • Latest main cloned and build

long-git-error-reproductible.mp4

$ cat .git/refs/tags/v1.1.2
70c990bc21c70a145e46edd9cf84738d3607ecc1
$ cat .git/HEAD
70c990bc21c70a145e46edd9cf84738d3607ecc1
$ git status
Not currently on any branch.
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        deleted:    recipes/common/usr/lib/systemd/system/local-fs.target.wants/bootc-generic-growpart.service
        deleted:    recipes/natural_language_processing/chatbot/quadlet/chatbot.image
        deleted:    recipes/natural_language_processing/codegen/quadlet/codegen.image
        deleted:    recipes/natural_language_processing/rag/quadlet/rag.image
        deleted:    recipes/natural_language_processing/summarizer/quadlet/summarizer.image
        deleted:    training/common/usr/lib/systemd/system/local-fs.target.wants/bootc-generic-growpart.service

@jeffmaury has the same issue as this. These missing files are symlinks in the repository. The problem seems to be that isomorphic-git is not able to clone symlink files on Windows (but it is working correctly on Linux and Mac)

@feloy
Copy link
Contributor

feloy commented Jun 5, 2024

I don't remember how I ran into this bug :-/

The only reason I can imagine to have this issue would be that you cloned the repository manually without fetching the tags (git clone --no-tags ... or similar). Or it could have been cloned with a previous version of ai-lab using the git command? Is it possible?

@benoitf
Copy link
Collaborator Author

benoitf commented Jun 5, 2024

so no, I did not any manual steps but probably I had a previous version.

but I suppose that if you start once and then stop and start it again later if you didn't do any manual steps between, should it prompt again the message ?

@feloy
Copy link
Contributor

feloy commented Jun 5, 2024

so no, I did not any manual steps but probably I had a previous version.

but I suppose that if you start once and then stop and start it again later if you didn't do any manual steps between, should it prompt again the message ?

No, you should not have this message if you don't change the state of the local repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📅 Planned
Development

No branches or pull requests

4 participants