Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing recipe from version control (git) #1095

Open
axel7083 opened this issue May 16, 2024 · 2 comments · May be fixed by #1097
Open

Importing recipe from version control (git) #1095

axel7083 opened this issue May 16, 2024 · 2 comments · May be fixed by #1097
Assignees
Labels
kind/epic Issue describing an epic kind/feature 💡 Issue for requesting a new feature
Milestone

Comments

@axel7083
Copy link
Contributor

axel7083 commented May 16, 2024

Is your feature request related to a problem? Please describe

After some discussion with people, sharing custom recipes is a bit tedious, we could other an import section allowing to import recipe from a git repository.

Describe the solution you'd like

A import button, copy paste the repository.

By default it would be looking at the root repository for the ai-lab.yaml file otherwise would ask the user where it is located.

We could also let them choose to import a local ai-lab.yaml.

Steps

Local import

  • Refactor the recipe system to allow Recipe object without repository

TODO

@axel7083 axel7083 added the kind/feature 💡 Issue for requesting a new feature label May 16, 2024
@axel7083 axel7083 self-assigned this May 16, 2024
@axel7083 axel7083 added this to the 1.2 milestone May 16, 2024
@axel7083 axel7083 linked a pull request May 17, 2024 that will close this issue
@axel7083 axel7083 added the kind/epic Issue describing an epic label May 17, 2024
@feloy
Copy link
Contributor

feloy commented May 21, 2024

Is your feature request related to a problem? Please describe

After some discussion with people, sharing custom recipes is a bit tedious, we could other an import section allowing to import recipe from a git repository.

Describe the solution you'd like

A import button, copy paste the repository.

By default it would be looking at the root repository for the ai-lab.yaml file otherwise would ask the user where it is located.

I remember you described during a call the problems encountered when trying to add a recipe to the catalog. But I don't remember you mentioned the possibility for the user to have its own catalog.json file in ~/.local/share/containers/podman-desktop/extensions-storage/redhat.ai-lab/catalog.json. Was this possibility considered by the users? (I understood you talked about rebuilding the extension with the modified catalog file)

@axel7083
Copy link
Contributor Author

axel7083 commented May 21, 2024

I remember you described during a call the problems encountered when trying to add a recipe to the catalog.

I am not sure to see exactly what issue we are talking about.

But I don't remember you mentioned the possibility for the user to have its own catalog.json file in ~/.local/share/containers/podman-desktop/extensions-storage/redhat.ai-lab/catalog.json. Was this possibility considered by the users? (I understood you talked about rebuilding the extension with the modified catalog file)

We currently allow user to have a user-catalog.json file located in the extension-storage yes, the format is the same as the one inside the assets folder. We are mixing both at runtime if exists. Currently we only offer the user to add models in it through the UI, but you can technically add recipe in it.

The issues that may happen are in the following cases;

  • You do not specify any categories for the recipe where it would not be displayed (fixed by feat: improve recipes page #1099)
  • You do not set any models for the recipe (You cannot start the recipe, you get a weird buggy state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Issue describing an epic kind/feature 💡 Issue for requesting a new feature
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants