Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if using fedora image and prompt / possibly auto-select XFS or ext4. #457

Closed
cdrage opened this issue May 7, 2024 · 0 comments · Fixed by #486
Closed

Detect if using fedora image and prompt / possibly auto-select XFS or ext4. #457

cdrage opened this issue May 7, 2024 · 0 comments · Fixed by #486
Assignees
Labels
kind/enhancement ✨ Issue for requesting an improvement

Comments

@cdrage
Copy link
Collaborator

cdrage commented May 7, 2024

Is your enhancement related to a problem? Please describe

fedora bootc by default you have to supply whether to use ext4 or xfs, which is intentional.

Describe the solution you'd like

warning or an auto-select of the filesystem type for when fedora is selected.

Describe alternatives you've considered

No response

Additional context

No response

@cdrage cdrage added the kind/enhancement ✨ Issue for requesting an improvement label May 7, 2024
@cdrage cdrage self-assigned this May 13, 2024
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue May 21, 2024
### What does this PR do?

* Detects if the base image is based upon fedora
* If it is based on fedora, auto-select the filesystem

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#457

### How to test this PR?

<!-- Please explain steps to reproduce -->

Select a fedora bootc image or manifest, it will auto-select XFS.

If you select a non-fedora bootc image, it will be default.

Tests also cover new feature

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue May 22, 2024
### What does this PR do?

* Detects if the base image is based upon fedora
* If it is based on fedora, auto-select the filesystem

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes containers#457

### How to test this PR?

<!-- Please explain steps to reproduce -->

Select a fedora bootc image or manifest, it will auto-select XFS.

If you select a non-fedora bootc image, it will be default.

Tests also cover new feature

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit that referenced this issue May 22, 2024
### What does this PR do?

* Detects if the base image is based upon fedora
* If it is based on fedora, auto-select the filesystem

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes #457

### How to test this PR?

<!-- Please explain steps to reproduce -->

Select a fedora bootc image or manifest, it will auto-select XFS.

If you select a non-fedora bootc image, it will be default.

Tests also cover new feature

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

1 participant