Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tinro from ui component library #7235

Closed
benoitf opened this issue May 16, 2024 · 3 comments · Fixed by #7288
Closed

remove tinro from ui component library #7235

benoitf opened this issue May 16, 2024 · 3 comments · Fixed by #7288
Assignees
Labels
area/ui-components kind/enhancement ✨ Issue for requesting an improvement

Comments

@benoitf
Copy link
Collaborator

benoitf commented May 16, 2024

Is your enhancement related to a problem? Please describe

Tab component brought the tinro component into the ui library

but the UI library should be agnostic on the routing system used by the framework.

Describe the solution you'd like

Need to refactor the tab component and remove tinro from package.json

Describe alternatives you've considered

No response

Additional context

No response

@benoitf benoitf added kind/enhancement ✨ Issue for requesting an improvement area/ui-components labels May 16, 2024
@lstocchi
Copy link
Contributor

I was moving during the call so i didn't quite follow the discussion but what's the reasoning behind this?
For the tab the router is just used to verify if the url passed to the component is equals to the current path and it applies the style accordingly. If i have to pass the tab url + the current path it's kinda ugly imo. I expect that the component changes the style automatically without me specifying the current page i'm on.

@benoitf
Copy link
Collaborator Author

benoitf commented May 16, 2024

it's that you may use the component to display a Tab object but you don't use the tinro library to manage how the pages are displayed

@benoitf
Copy link
Collaborator Author

benoitf commented May 16, 2024

maybe there is a Tab in UI library to display something and the matching of style is done in some callbacks, helper library maintained by either a Podman Desktop Tab component (using tinro) or other ways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-components kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants