Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow second user switch #1409

Closed
aschempp opened this issue Feb 26, 2020 · 3 comments · Fixed by #1581
Closed

Allow second user switch #1409

aschempp opened this issue Feb 26, 2020 · 3 comments · Fixed by #1581
Assignees
Labels
Milestone

Comments

@aschempp
Copy link
Member

As assumed in #314, Symfony has fixed the ability to switch to another user a second time in symfony/symfony#35839

We should therefore revert #345 in Contao 4.9 (and raise the minimum requirement)

@aschempp aschempp added the bug label Feb 26, 2020
@aschempp aschempp added this to the 4.9 milestone Feb 26, 2020
@bytehead bytehead self-assigned this Feb 26, 2020
@leofeyer
Copy link
Member

leofeyer commented Feb 27, 2020

The fix has not yet been merged upstream, so we still have to wait. And there is yet another problem which the fix does not solve:

  1. In the COD, make "h.lewis" a second administrator.
  2. Log in as "k.jones" and switch to "h.lewis".
  3. Go to the user module and switch to "k.jones".
  4. Now the back end top menu says "Go back to k.jones" instead of "Log out". 🤷‍♂

@leofeyer leofeyer added the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Feb 27, 2020
@aschempp
Copy link
Member Author

That's correct, you're switching back to the user that initially logged in. I'd say we should just disable the second user switch to the original user.

@leofeyer
Copy link
Member

As discussed in Mumble on March, 12th, we want to disable the impersonate button that would take the user back to themselves.

@leofeyer leofeyer removed the up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. label Mar 12, 2020
leofeyer added a commit that referenced this issue Mar 27, 2020
… user (see #1581)

Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | Fixes #1409
| Docs PR or issue | -

Commits
-------

05eab41 Disable the "switch user" button if it would impersonate the original user
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants