Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the assets folder #7093

Closed
leofeyer opened this issue Apr 5, 2024 · 2 comments · May be fixed by #7094
Closed

Stop using the assets folder #7093

leofeyer opened this issue Apr 5, 2024 · 2 comments · May be fixed by #7094
Assignees
@leofeyer
Labels
feature
Milestone
5.4

Comments

@leofeyer
Copy link
Member

leofeyer commented Apr 5, 2024

Description

Our goal is not to use the assets folder anymore, because it is "reserved" for the Symfony app. Therefore:

  1. Install the Contao components into public/components.

  2. Move the assets/{css,images,js} folders to public/assets/{css,images,js}, so the existing paths in CDNs and other caches don‘t change.

Also see #7013.
@leofeyer leofeyer added this to the 5.4 milestone Apr 5, 2024
@leofeyer leofeyer mentioned this issue Apr 5, 2024
Closed
@leofeyer leofeyer self-assigned this Apr 5, 2024
@asaage
Copy link

asaage commented Apr 5, 2024 •
edited

That would result in contao/public/public/assets/ (first public beeing the webroot) and looks really strange 🤔

@fritzmg
Copy link
Contributor

fritzmg commented Apr 5, 2024

@asaage you are misinterpreting the paths. All the paths are relative to the project's directory.

@leofeyer leofeyer mentioned this issue Apr 5, 2024
Open
@leofeyer leofeyer linked a pull request Apr 5, 2024 that will close this issue
Move the assets folder to public/assets #7094
Open
@leofeyer leofeyer closed this as completed Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

Move the assets folder to public/assets leofeyer/contao
3 participants
@leofeyer @asaage @fritzmg