Inserttags do not parse within the breadcrumb module

[zoglo]

Affected version(s)

5.3.x

Description

It was common to use the insert tag {{page::pageTitle}} for detail pages in news to generate the page title within the breadcrumb.

This seems broken in Contao 5.3.x and can even be seen in the demo when using {{page::pageTitle}}:
https://demo.contao.org/news/new-contao-versions-in-short-intervalls.html

[fritzmg]

Sort of a duplicate of #6050. While the cause in #6050 is different (here it is caused by the more granular replacement of insert tags) the eventual solution likely needs to be the same.

// edit: oh, they are not replaced with the page title at all? That's something different then may be.

[asaage]

it works if the breadcrumb comes after the reader
https://community.contao.org/de/showthread.php?86441-order-of-operations&p=581453#post581453
I'd appreciate if somebody finds a solution where you don't even have to insert {{page::pageTitle}} into the pageName because it makes the PageTreeview in the Backend look like a hack.

[zoglo]

I'd appreciate if somebody finds a solution where you don't even have to insert {{page::pageTitle}} into the pageName because it makes the PageTreeview in the Backend look like a hack.

@asaage feel free to adjust the logic and implement it for Contao. It ain't flawless and needs some tests as well:
https://github.com/oveleon/contao-glossary-bundle/blob/main/src/EventListener/BreadcrumbListener.php

That would most likely be a feature tho

[zoglo]

After debugging, this happens most likely within these lines:

contao/core-bundle/contao/library/Contao/InsertTags.php

Lines 107 to 120 in 2c84dec

	$strRegExpStart = '{{' // Starts with two opening curly braces
	. '(' // Match the contents of the tag
	. '[a-zA-Z0-9\x80-\xFF]' // The first letter must not be a reserved character of Twig, Mustache or similar template engines (see #805)
	. '(?>[^{}]|' // Match any character not curly brace or a nested insert tag
	;
	$strRegExpEnd = ')*+)}}'; // Ends with two closing curly braces
	$tags = preg_split(
	'(' . $strRegExpStart . str_repeat('{{(?:' . substr($strRegExpStart, 3), 9) . str_repeat($strRegExpEnd, 10) . ')',
	$strBuffer,
	-1,
	PREG_SPLIT_DELIM_CAPTURE
	);

since it outputs $tags with a size of 1, thus returning a ChunkedText.

[ausi]

After debugging, this happens most likely within these lines:

what do you mean by that?

[zoglo]

what do you mean by that?

Basically how far my investigation went.
$tags is actually an array that looks like this:

$tags = [
    '',
    '{{page::pageTitle}},
    ''
]

Basically, the regex does not work because the expected output should look like this:

$tags = [
    'page',
    'pageTitle',
]

[ausi]

$tags is actually an array that looks like this:

No, it looks like ['', 'page::pageTitle', ''] (the middle part without {{ and }})
But anyway, this is not related to this issue as far as I can tell, as the {{page::pageTitle}} insert tag itself works just fine, only in the breadcrumb module there seems to be an issue, right?

[zoglo]

Yeah, debugged late at night so maybe a wrong conclusion

[netzarbeiter]

As an addition: If you add a headline with the content {{page::pageTitle}} to the news detail page the output in Contao 5 is "News and updates" the page title of the page. In Contao 4.13 it was the title of the news "New Contao Versions in short intervalls".

https://demo.contao.org/preview.php/news/new-contao-versions-in-short-intervalls.html

[asaage]

As an addition: If you add a headline with the content {{page::pageTitle}} to the news detail page

I noticed the same while using a detail-page with the reader-module from plenta/contao-jobs-basic-bundle.
Is it possible to delay the resolving of this Inserttag {{page::pageTitle}} (probably others as well) until every module that changes something has done it's thing? The culprit seems to be located there more than actualy in the breadcrumb module.

[fritzmg]

I still think that the correct solution for this issue are - in my opinion - reader pages.