Static data providers required in PHPUnit 10

[leofeyer]

Description

PHPUnit 10 requires all data providers to be static, however, we have about 40 that use $this->createMock() or $this->mockClassWithProperties(). For example:

contao/core-bundle/tests/Cache/EntityCacheTagsTest.php

Lines 146 to 166 in f7f4cdc

	$page1 = $this->mockClassWithProperties(PageModel::class, except: ['getTable']);
	$page1->id = 5;
	$page2 = $this->mockClassWithProperties(PageModel::class, except: ['getTable']);
	$page2->id = 6;
	$modelCollection = new Collection([$page1, $page2], 'tl_page');
	yield 'specific tag for entity instance' => [
	$post,
	['contao.db.tl_blog_post.5'],
	];
	yield 'specific tag for model instance' => [
	$page1,
	['contao.db.tl_page.5'],
	];
	yield 'mixed' => [
	[$post, $post->getAuthor(), $post->getComments(), $post->getTags(), $modelCollection, ArticleModel::class, 'foo'],
	[

I have no idea how to fix this without encapsulating the code in a separate test method. We could of course replace every $this->createMock() with (new class() extends TestCase {})->createMock() in the static methods, but then these doubled types would no longer be tracked in the original test case object.

[ausi]

We could probably use (new MockGenerator)->testDouble(…) directly?

but then these doubled types would no longer be tracked in the original test case object.

Do they need to be tracked? If they don’t have any assertions that should not be needed I think.

[leofeyer]

I don‘t know. The createMock() method calls $this->registerMockObject() which adds the object to the TestCase::$mockObjects property.

[aschempp]

I think it would be better to pass the mock object data from the generator method to the test method, and create the mock in there. or simply fix it like #7150