User can drag/drop files onto a non-mounted folder

[aschempp]

Affected version(s)

5.3

Description

Since Contao 5.3 (I think) the parent folders of mounted folder are visible in the file tree. When drag & dropping a file throught the drag handle, the user can also drop it on a non-mounted (parent) folder. Access permissions are checked correctly, so this will result in an exception. I think it would be best to use a class or data attribute to mark folders that should be droppable and the ones that should not be.

[leofeyer]

@ausi Am I right in assuming that we have to add a CSS class to these parent folders and adjust the droppables elements accordingly?

contao/core-bundle/assets/scripts/core.js

Line 947 in 67130d0

droppables: $$([ul]).append(ul.getElements('.tl_folder,li.parent,.tl_folder_top')),

[ausi]

Probably needs to be adjusted here as well I think:

contao/core-bundle/assets/scripts/core.js

Line 978 in 67130d0

move.droppables = $$([ul]).append(ul.getElements('.tl_folder,li.parent'));

contao/core-bundle/assets/scripts/core.js

Line 1045 in 67130d0

return droppable.getPrevious('.tl_folder');

contao/core-bundle/assets/scripts/core.js

Lines 1886 to 1891 in 67130d0

	var folder = target.match('.tl_folder') ? target : target.getParent('.tl_folder');
	if (!folder) {
	folder = target.getParent('.parent');
	folder = folder && folder.getPrevious('.tl_folder');
	}