Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: conventional-changelog/commitlint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.3.2
Choose a base ref
...
head repository: conventional-changelog/commitlint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.3.3
Choose a head ref
  • 3 commits
  • 14 files changed
  • 2 contributors

Commits on Oct 22, 2019

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3ed8009 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    11b920b View commit details
  3. v8.3.3

    byCedric committed Oct 22, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9a1dd6f View commit details
4 changes: 2 additions & 2 deletions @alias/commitlint/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "commitlint",
"version": "8.3.2",
"version": "8.3.3",
"description": "Lint your commit messages",
"files": [
"cli.js"
@@ -34,7 +34,7 @@
},
"license": "MIT",
"dependencies": {
"@commitlint/cli": "^8.3.2",
"@commitlint/cli": "^8.3.3",
"read-pkg": "5.2.0",
"resolve-pkg": "2.0.0"
},
4 changes: 2 additions & 2 deletions @commitlint/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/cli",
"version": "8.3.2",
"version": "8.3.3",
"description": "Lint your commit messages",
"files": [
"index.js",
@@ -72,7 +72,7 @@
"dependencies": {
"@commitlint/format": "^8.3.2",
"@commitlint/lint": "^8.3.2",
"@commitlint/load": "^8.3.2",
"@commitlint/load": "^8.3.3",
"@commitlint/read": "^8.3.2",
"babel-polyfill": "6.26.0",
"chalk": "2.4.2",
4 changes: 2 additions & 2 deletions @commitlint/config-conventional/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/config-conventional",
"version": "8.3.2",
"version": "8.3.3",
"description": "Shareable commitlint config enforcing conventional commits",
"files": [
"index.js"
@@ -35,6 +35,6 @@
"@commitlint/utils": "^8.3.0"
},
"dependencies": {
"conventional-changelog-conventionalcommits": "4.1.0"
"conventional-changelog-conventionalcommits": "4.2.1"
}
}
4 changes: 2 additions & 2 deletions @commitlint/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/core",
"version": "8.3.2",
"version": "8.3.3",
"description": "Lint your commit messages",
"files": [
"index.js"
@@ -34,7 +34,7 @@
"dependencies": {
"@commitlint/format": "^8.3.2",
"@commitlint/lint": "^8.3.2",
"@commitlint/load": "^8.3.2",
"@commitlint/load": "^8.3.3",
"@commitlint/read": "^8.3.2"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
parserPreset: 'conventional-changelog-conventionalcommits'
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "parser-preset-conventional-without-factory",
"version": "1.0.0",
"devDependencies": {
"conventional-changelog-conventionalcommits": "4.2.1"
}
}
2 changes: 1 addition & 1 deletion @commitlint/load/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/load",
"version": "8.3.2",
"version": "8.3.3",
"description": "Load shared commitlint configuration",
"main": "lib/index.js",
"files": [
10 changes: 9 additions & 1 deletion @commitlint/load/src/index.js
Original file line number Diff line number Diff line change
@@ -137,9 +137,17 @@ async function loadParserOpts(parserName, pendingParser) {
startsWith(parserName, 'conventional-changelog-')
) {
return await new Promise(resolve => {
parser.parserOpts((_, opts) => {
const result = parser.parserOpts((_, opts) => {
resolve(opts.parserOpts);
});

// If result has data or a promise, the parser doesn't support factory-init
// due to https://github.com/nodejs/promises-debugging/issues/16 it just quits, so let's use this fallback
if (result) {
Promise.resolve(result).then(opts => {
resolve(opts.parserOpts);
});
}
});
}

14 changes: 14 additions & 0 deletions @commitlint/load/src/index.test.js
Original file line number Diff line number Diff line change
@@ -368,3 +368,17 @@ test('recursive resolves parser preset from conventional atom', async t => {
t.is(typeof actual.parserPreset.parserOpts, 'object');
t.deepEqual(actual.parserPreset.parserOpts.headerPattern, /^(:.*?:) (.*)$/);
});

test('resolves parser preset from conventional commits without factory support', async t => {
const cwd = await npm.bootstrap(
'fixtures/parser-preset-conventional-without-factory'
);
const actual = await load({}, {cwd});

t.is(actual.parserPreset.name, 'conventional-changelog-conventionalcommits');
t.is(typeof actual.parserPreset.parserOpts, 'object');
t.deepEqual(
actual.parserPreset.parserOpts.headerPattern,
/^(\w*)(?:\((.*)\))?!?: (.*)$/
);
});
4 changes: 2 additions & 2 deletions @commitlint/prompt-cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/prompt-cli",
"version": "8.3.2",
"version": "8.3.3",
"description": "commit prompt using commitlint.config.js",
"files": [
"cli.js"
@@ -34,7 +34,7 @@
"ava": "0.25.0"
},
"dependencies": {
"@commitlint/prompt": "^8.3.2",
"@commitlint/prompt": "^8.3.3",
"execa": "0.11.0",
"string-to-stream": "3.0.1"
}
4 changes: 2 additions & 2 deletions @commitlint/prompt/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/prompt",
"version": "8.3.2",
"version": "8.3.3",
"description": "commitizen prompt using commitlint.config.js",
"main": "./lib/index.js",
"files": [
@@ -65,7 +65,7 @@
"cross-env": "6.0.3"
},
"dependencies": {
"@commitlint/load": "^8.3.2",
"@commitlint/load": "^8.3.3",
"babel-runtime": "^6.23.0",
"chalk": "^2.0.0",
"lodash": "4.17.15",
4 changes: 2 additions & 2 deletions @commitlint/travis-cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/travis-cli",
"version": "8.3.2",
"version": "8.3.3",
"description": "Lint all relevant commits for a change or PR on Travis CI",
"files": [
"lib/"
@@ -65,7 +65,7 @@
"which": "2.0.1"
},
"dependencies": {
"@commitlint/cli": "^8.3.2",
"@commitlint/cli": "^8.3.3",
"babel-runtime": "6.26.0",
"execa": "0.11.0"
}
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -2,5 +2,5 @@
"lerna": "2",
"npmClient": "yarn",
"useWorkspaces": true,
"version": "8.3.2"
"version": "8.3.3"
}
9 changes: 5 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
@@ -3708,12 +3708,13 @@ conventional-changelog-angular@^5.0.3:
compare-func "^1.3.1"
q "^1.5.1"

conventional-changelog-conventionalcommits@4.1.0:
version "4.1.0"
resolved "https://registry.npmjs.org/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-4.1.0.tgz#eb7d47a9c5f1a6f9846a649482294e4ac50d7683"
integrity sha512-J3xolGrH8PTxpCqueHOuZtv3Cp73SQOWiBQzlsaugZAZ+hZgcJBonmC+1bQbfGs2neC2S18p2L1Gx+nTEglJTQ==
conventional-changelog-conventionalcommits@4.2.1:
version "4.2.1"
resolved "https://registry.npmjs.org/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-4.2.1.tgz#d6cb2e2c5d7bfca044a08b9dba84b4082e1a1bd9"
integrity sha512-vC02KucnkNNap+foDKFm7BVUSDAXktXrUJqGszUuYnt6T0J2azsbYz/w9TDc3VsrW2v6JOtiQWVcgZnporHr4Q==
dependencies:
compare-func "^1.3.1"
lodash "^4.2.1"
q "^1.5.1"

conventional-changelog-core@^3.1.6: