Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--verbose not available for commitlint-travis & probable commilint typo in cli.test.js #1695

Closed
1 of 4 tasks
myii opened this issue May 12, 2020 · 3 comments
Closed
1 of 4 tasks
Labels

Comments

@myii
Copy link

myii commented May 12, 2020

In terms of the potential bug via. typo (commilint instead of commitlint):

The main issue follows below.

Expected Behavior

Prior to version 8.x.x of commitlint-travis, we used to get what is now --verbose output:

https://travis-ci.com/github/saltstack-formulas/template-formula/jobs/180027460#L481-L513

+ @commitlint/travis-cli@7.5.2
...

The command "npm install @commitlint/travis-cli -D" exited with 0.

$ commitlint-travis
Already up to date!

   input: docs(contributing): modify quoted heading to prevent TOC inclusion
   found 0 problems, 0 warnings 
    (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint )

   input: docs(contributing): add basic introductory text before the TOC
   found 0 problems, 0 warnings 
    (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint )

   input: docs(readme): convert note into a heading
   found 0 problems, 0 warnings 
    (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint )

   input: feat(toc): use `markdown-toc` directly to update inline
   found 0 problems, 0 warnings 
    (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint )

The command "commitlint-travis" exited with 0.

Current Behavior

Now we only get terse output, even if attempting to use --verbose:

https://travis-ci.org/github/myii/ssf-formula/jobs/685988278#L315-L326

+ @commitlint/travis-cli@8.3.5
...

The command "npm i -D @commitlint/config-conventional @commitlint/travis-cli" exited with 0.

$ commitlint-travis --verbose
Already up to date!
The command "commitlint-travis --verbose" exited with 0.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

We would really appreciate being able to pass through the --verbose option.

Steps to Reproduce (for bugs)

  1. First step
  2. Second step
commitlint.config.js ```js ```

Context

Your Environment

Executable Version
commitlint --version VERSION
git --version VERSION
node --version VERSION
@myii myii changed the title --verbose not available for commitlint-travis & probable typo commilint typo in cli.test.js --verbose not available for commitlint-travis & probable commilint typo in cli.test.js May 12, 2020
@escapedcat escapedcat added the bug label May 12, 2020
@armano2
Copy link
Contributor

armano2 commented Dec 15, 2020

i'm going to take a look on this, in version 7.6.1 (latest before 8 there was "no" enabled tests)
https://github.com/conventional-changelog/commitlint/blob/v7.6.1/%40commitlint/travis-cli/src/cli.test.js

@armano2
Copy link
Contributor

armano2 commented Dec 15, 2020

ok, this issue seem to be fixed already in #891

@escapedcat this issue can be closed as is already tested and it working

@escapedcat
Copy link
Member

Sweet, thanks for checking @armano2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants