-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conventional-changelog-writer): writerOpts supports timeZone #1162
Merged
dangreen
merged 10 commits into
conventional-changelog:master
from
takuminish:conventional-changelog-writer/add_timezone_option
Nov 13, 2023
Merged
feat(conventional-changelog-writer): writerOpts supports timeZone #1162
dangreen
merged 10 commits into
conventional-changelog:master
from
takuminish:conventional-changelog-writer/add_timezone_option
Nov 13, 2023
+63
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangreen
requested changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
takuminish
commented
Nov 12, 2023
takuminish
commented
Nov 12, 2023
dangreen
requested changes
Nov 12, 2023
dangreen
approved these changes
Nov 13, 2023
@takuminish Thanks! |
@dangreen Thanks for merging the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I'm a user of this project.
Sorry... I use deepl because I am not good at English.
I've faced a problem that same as #594.
I created the PR because I thought it would be better to be able to set timeZone in writerOpts.
summary
add timezone option to writerOpts(#594 (comment))
The default value is 'UTC' to avoid breaking changes in the conventional-changelog-writer.
Usage
When a non-existent timezone is specified
When a non-existent timezone is specified, I get an error like the following.
Or should I catch the error?
If you like it, could you please review and merge this PR?
If further additional code or test is needed, we will accommodate.