fix(angular): revert pattern to not require a period #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangreen
requested changes
Nov 19, 2023
|
Couldn't figure out how to make the negative test work for SHAs less than 7 characters or more than 40 characters. Something was still picking up the Would you mind looking into it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per their spec, there is no period required at the end of the commit SHA:
https://github.com/angular/angular/blob/main/CONTRIBUTING.md#revert-commits
Also, as a fix, I set a minimum requirement of 7 characters for the SHA (Git default) as currently you can pass in nothing and it would still work.