Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: cleanup presets interface #1215

Merged
merged 1 commit into from
Mar 10, 2024
Merged

feat!: cleanup presets interface #1215

merged 1 commit into from
Mar 10, 2024

Conversation

dangreen
Copy link
Member

BREAKING CHANGES: now preset object provides commits, parser, writer and whatBump properties.

@coveralls
Copy link

coveralls commented Mar 10, 2024

Coverage Status

coverage: 91.644% (-0.3%) from 91.924%
when pulling 973241a on feat-cleanup-presets
into 30cfa82 on master.

BREAKING CHANGES: now preset object provides `commits`, `parser`, `writer` and `whatBump` properties.
@dangreen dangreen merged commit 0e4f293 into master Mar 10, 2024
10 checks passed
@dangreen dangreen deleted the feat-cleanup-presets branch March 10, 2024 22:17
@knocte
Copy link
Contributor

knocte commented Mar 14, 2024

@dangreen I'm just curious, when do you plan to release a new version with this breaking change?

@dangreen dangreen added this to the next+1 milestone Mar 14, 2024
@dangreen
Copy link
Member Author

@knocte We have milestone for next release, but I can't name a date, because it depends on my free time.

@knocte
Copy link
Contributor

knocte commented Mar 15, 2024

but I can't name a date, because it depends on my free time.

I'm of course not asking for it to be earlier rather than later. If anything, it would be the other way around; because I'm trying to understand why the last version of this pkg was released so long ago: https://www.npmjs.com/package/conventional-commits-parser?activeTab=versions

@dangreen
Copy link
Member Author

@knocte Because there are packages that depends on conventional-commits-parser that also should be updated. So I have plan to publish all updated packages at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants