fix(preset): recommended-bump ESLint preset #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With commit 60815b5, it seems that the Angular preset was inadvertently copied into the ESLint package. This corrects the `conventional-recommended-bump` ESLint preset in `conventional-changelog-eslint` to behave the same as the built-in ESLint preset that was removed with conventional-changelog#270. Related to conventional-changelog#241
|
I'm really sorry! This was definitely a big mistake on my part. 👍 This change looks good to me. |
|
Version 1.0.5 has been released. |
Merged
|
Thanks for merging, and the quick release. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project, we recently started to use
conventional-recommended-bump(version 2.0.6) and it was giving us wrong results withnpx conventional-recommended-bump -p eslint. The latest version that works with-p eslintseems to be 1.2.1 (with built-in presets).It seems that the Angular preset was inadvertently copied into the ESLint package with commit 60815b5.
This corrects the
conventional-recommended-bumpESLint preset inconventional-changelog-eslintto behave the same as the built-in ESLint preset that was removed with #270.Related to #241