fix(preset): ESLint recommended-bump is always "patch" #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommended version bump detection with ESLint preset is broken since `conventional-changelog-eslint` version 3.0.0: `npx conventional-recommended-bump -p eslint` always returns "patch". This is because the preset's `parserOpts` (re-used with v3.0.0) "headerCorrespondence" is set to `['tag', 'message']` rather than `['type', 'subject']`, which was used before in the [ESLint preset "conventional-recommended-bump" specific `parserOpts`][1]. This adapts the ESLint preset's `whatBump` implementation to check "tag" instead of "type", which fixes the issue. [1]: https://github.com/conventional-changelog/conventional-changelog/blob/ce1fd981f88ce201e996dfa833e4682de3aafcdd/packages/conventional-changelog-eslint/conventional-recommended-bump.js#L32-L35
ingmarh
force-pushed
the
fix/eslint-recommended-bump
branch
from
dc62eb3
to
c756a68
Compare
|
Thanks @ingmarh ! Feel free to add some tests... |
eladchen
reviewed
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended version bump detection with ESLint preset is broken since
conventional-changelog-eslintversion 3.0.0:npx conventional-recommended-bump -p eslintalways returns "patch".This is because the preset's
parserOpts(re-used with v3.0.0)"headerCorrespondence" is set to
['tag', 'message']rather than['type', 'subject'], which was used before in the ESLint preset"conventional-recommended-bump" specific
parserOpts.This adapts the ESLint preset's
whatBumpimplementation to check "tag"instead of "type", which fixes the issue.