From 8a414ca2c277a976f30497564d14ae4f51753e43 Mon Sep 17 00:00:00 2001
From: Georgios Kaleadis <georgios@kaleadis.de>
Date: Thu, 28 Mar 2019 15:06:44 +0100
Subject: [PATCH] fix: side effects

---
 lib/lifecycles/commit.js | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lib/lifecycles/commit.js b/lib/lifecycles/commit.js
index d7c83580e..5beba6e82 100644
--- a/lib/lifecycles/commit.js
+++ b/lib/lifecycles/commit.js
@@ -20,12 +20,12 @@ module.exports = function (args, newVersion) {
 function execCommit (args, newVersion) {
   var msg = 'committing %s'
   var paths = []
-  var toAdd = ' '
+  var toAdd = ''
 
   // only start with a pre-populated paths list when CHANGELOG processing is not skipped
   if (!args.skip.changelog) {
     paths = [args.infile]
-    toAdd += args.infile + ' '
+    toAdd += args.infile
   }
 
   var verify = args.verify === false || args.n ? '--no-verify ' : ''
@@ -43,6 +43,12 @@ function execCommit (args, newVersion) {
     }
   })
   checkpoint(args, msg, paths)
+
+  if (args.skip.changelog && args.skip.bump && toAdd.length === 0) {
+    // nothing to do
+    return Promise.resolve()
+  }
+
   return runExec(args, 'git add' + toAdd)
     .then(() => {
       return runExec(args, 'git commit ' + verify + (args.sign ? '-S ' : '') + (args.commitAll ? '' : (toAdd)) + ' -m "' + formatCommitMessage(args.message, newVersion) + '"')