Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: conventional-changelog/standard-version
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.1
Choose a base ref
...
head repository: conventional-changelog/standard-version
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.0.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Jul 14, 2020

  1. fix: Commit message and tag name is no longer enclosed in quotes. (#619) 

    - Authored by @runnerway – runExecFile (`child_process.execFile`) does not need additional quotes/escaping.

Closes #621, #620
    @runnerway
    runnerway authored Jul 14, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    spencerschrock Spencer Schrock
    SSH Key Fingerprint: iEdk6w6vKX4x8FmfzRZODCotdCVMA333R1fASrXv690
    Verified
    Learn about vigilant mode
    Copy the full SHA
    ae032bf View commit details

  2. chore: release 8.0.2 (#622)

    @release-please
    release-please[bot] authored Jul 14, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    spencerschrock Spencer Schrock
    SSH Key Fingerprint: iEdk6w6vKX4x8FmfzRZODCotdCVMA333R1fASrXv690
    Verified
    Learn about vigilant mode
    Copy the full SHA
    91cd83c View commit details
Showing with 12 additions and 5 deletions.
  1. +7 −0 CHANGELOG.md
  2. +1 −1 lib/lifecycles/commit.js
  3. +1 −1 lib/lifecycles/tag.js
  4. +1 −1 package.json
  5. +2 −2 test.js
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [8.0.2](https://www.github.com/conventional-changelog/standard-version/compare/v8.0.1...v8.0.2) (2020-07-14)


### Bug Fixes

* Commit message and tag name is no longer enclosed in quotes. ([#619](https://www.github.com/conventional-changelog/standard-version/issues/619)) ([ae032bf](https://www.github.com/conventional-changelog/standard-version/commit/ae032bfa9268a0a14351b0d78b6deedee7891e3a)), closes [#621](https://www.github.com/conventional-changelog/standard-version/issues/621) [#620](https://www.github.com/conventional-changelog/standard-version/issues/620)

### [8.0.1](https://www.github.com/conventional-changelog/standard-version/compare/v8.0.0...v8.0.1) (2020-07-12)


2 changes: 1 addition & 1 deletion lib/lifecycles/commit.js
View file
Original file line number Diff line number Diff line change
@@ -67,7 +67,7 @@ function execCommit (args, newVersion) {
args.commitAll ? [] : toAdd,
[
'-m',
`"${formatCommitMessage(args.releaseCommitMessageFormat, newVersion)}"`
`${formatCommitMessage(args.releaseCommitMessageFormat, newVersion)}`
]
)
)
2 changes: 1 addition & 1 deletion lib/lifecycles/tag.js
View file
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ function execTag (newVersion, pkgPrivate, args) {
tagOption = '-a'
}
checkpoint(args, 'tagging release %s%s', [args.tagPrefix, newVersion])
return runExecFile(args, 'git', ['tag', tagOption, args.tagPrefix + newVersion, '-m', `"${formatCommitMessage(args.releaseCommitMessageFormat, newVersion)}"`])
return runExecFile(args, 'git', ['tag', tagOption, args.tagPrefix + newVersion, '-m', `${formatCommitMessage(args.releaseCommitMessageFormat, newVersion)}`])
.then(() => runExecFile('', 'git', ['rev-parse', '--abbrev-ref', 'HEAD']))
.then((currentBranch) => {
let message = 'git push --follow-tags origin ' + currentBranch.trim()
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "standard-version",
"version": "8.0.1",
"version": "8.0.2",
"description": "replacement for `npm version` with automatic CHANGELOG generation",
"bin": "bin/cli.js",
"scripts": {
4 changes: 2 additions & 2 deletions test.js
View file
Original file line number Diff line number Diff line change
@@ -263,8 +263,8 @@ describe('cli', function () {
return line ? JSON.parse(line) : line
})
/* eslint-disable no-useless-escape */
captured[captured.length - 4].should.deep.equal(['commit', '-S', 'CHANGELOG.md', 'package.json', '-m', '\"chore(release): 1.0.1\"'])
captured[captured.length - 3].should.deep.equal(['tag', '-s', 'v1.0.1', '-m', '\"chore(release): 1.0.1\"'])
captured[captured.length - 4].should.deep.equal(['commit', '-S', 'CHANGELOG.md', 'package.json', '-m', 'chore(release): 1.0.1'])
captured[captured.length - 3].should.deep.equal(['tag', '-s', 'v1.0.1', '-m', 'chore(release): 1.0.1'])
/* eslint-enable no-useless-escape */
unmock()
})