Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-json files support for version bump #313

Closed
sobolevn opened this issue Mar 15, 2019 · 5 comments
Closed

Non-json files support for version bump #313

sobolevn opened this issue Mar 15, 2019 · 5 comments
Assignees

Comments

@sobolevn
Copy link

Hi, thanks for this awesome tool!

I am using this project with great success with node eco-system.
But, I also use other languages as well. And these languages have different meta-files format.
For example,

And not to mention cargo.toml for rust, haskell, nix, etc.
It is clear that it is impossible to know about all these formats in advance.

So, I suggest to add some kind of regex or sed provider to change version inside these files. What do you think?

Thanks!

@jbottigliero
Copy link
Member

Hey – thanks for the suggestion, I agree that this is something that would be useful!

I'm going to link this ticket to #271 as it seems like the implementation should be able to resolve both issues.


At the moment the bump lifecycle (bump.js[updateConfigs]) is explicitly parsing the file where we write the version as JSON, but it seems like we should be able to alter this behavior based on a configuration value. There are some overhauls in configuration happening at the moment that we should probably land before adding more options, but I'm putting this on my radar.

Thanks again!

@Heziode
Copy link

Heziode commented Nov 23, 2019

Another approach, maybe add a version or .version file that only contains the current version.

@Heziode
Copy link

Heziode commented Dec 7, 2019

@jbottigliero,

With #372 merged, this issue should be solved/closed, isn'it ?

@sobolevn
Copy link
Author

sobolevn commented Dec 8, 2019

Yeap.

@sobolevn sobolevn closed this as completed Dec 8, 2019
@jbottigliero
Copy link
Member

Hey – while the work here has been completed, keep in mind this has not landed in a published release just yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants