Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use const based on new eslint rules #329

Merged
merged 3 commits into from May 5, 2019
Merged

test: use const based on new eslint rules #329

merged 3 commits into from May 5, 2019

Conversation

jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Apr 27, 2019

This was caused by tests in #320 using var and being merged into the trunk (as-is) just before the new eslint rules (#321)


This should fix the build errors we're seeing in some of the latest PRs.

Joe Bottigliero and others added 2 commits May 5, 2019 12:06
This was caused by tests in #320 using `var` and being merged into the trunk (as-is) just before the new eslint rules (#321)
@bcoe bcoe merged commit b6d3d13 into master May 5, 2019
@bcoe bcoe deleted the fix-ci-eslint branch May 5, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants