Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bump): transmit tag prefix argument to conventionalRecommendedBump #393

Conversation

Neonox31
Copy link
Contributor

@Neonox31 Neonox31 commented Jul 8, 2019

The prefixTag is never transmitted to conventionalRecommendedBump parameters.
In my case, I have a monorepo with several prefixed tags and standard-version would always bump to major because of using wrong "from" tag.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 69b7d2e on Neonox31:fix-bump-transmit-tag-prefix-argument-to-conventionalRecommendedBump into c9cb339 on conventional-changelog:master.

@bcoe
Copy link
Member

bcoe commented Jul 9, 2019

@Neonox31 thanks for the patch 👍 will try to land soon.

@Neonox31
Copy link
Contributor Author

Hello, any news on it ?

@jbottigliero
Copy link
Member

Hey @Neonox31 – this change looks good to me and I've added this to what I'd like to see land in the next published release. I'm working on coordinating the release with the rest of the conventional-changelog org now... but I'm hoping we can land this before the end of the month!

Thanks for understanding and your contribution!

@Neonox31
Copy link
Contributor Author

OK thanks !

@bcoe bcoe merged commit 8205222 into conventional-changelog:master Jul 29, 2019
@bcoe
Copy link
Member

bcoe commented Jul 29, 2019

@Neonox31 thank you for the contribution 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants