New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor version bumps in preMajor packages #714
Comments
I think, this has been discussed in #308, #310, #347 and #454 (among others). However, this not being configurable makes the whole tool unusable for me. |
You basically have to make commits with I agree it would be nice to have a flag to override this behavior. |
This feels like driving on the opposite side of the road. The theoretical advantages may be irrefutable, but if only some people do it, it'll still cause more harm than good. |
I also noticed this and started digging around what might cause it. would be nice if this thing had a flag or something. after some more digging, I came to this comment and it clicked for me: conventional-changelog/conventional-changelog#452 (comment) and to create a minor release during 0.x.x, you have to create a breaking change, but since it is pre-major, it will just bump the minor. |
I work with something different to "npm", thought this was the right tool for that... |
This "preMajor" feature is a POLA violation and should be fixed. From your README:
From Conventional Commits Specification:
What part of that isn't clear? For anyone that wants this |
Definitely the documentation is unclear, or even a Conventional Commit Spec change is required for this. |
After some head banging and source code debugging about why any release of our preMajor package was only bumping to 'patch' versions we discovered that anything below 1.0.0 is forced into a patch release regardless of whether a "feature" is detected by a "feat" prefix.
preMajor option being forced to true
standard-version/lib/lifecycles/bump.js
Line 117 in 0a801d9
forces a level 2 bump which equates to a forced patch
https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog-conventionalcommits/conventional-recommended-bump.js#L31
Perhaps there is sound reasoning as to why but is there anyway to allow minor bumps before a v1 major release?
The text was updated successfully, but these errors were encountered: