Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using both prelease and release-as parameters, the version number becomes null #542

Open
wwh0219 opened this issue Feb 10, 2020 · 0 comments · Fixed by absolute-version/commit-and-tag-version#8 · May be fixed by #767
Open

Using both prelease and release-as parameters, the version number becomes null #542

wwh0219 opened this issue Feb 10, 2020 · 0 comments · Fixed by absolute-version/commit-and-tag-version#8 · May be fixed by #767

Comments

@wwh0219
Copy link

wwh0219 commented Feb 10, 2020

There was a problem when I specified a new pre-release version number

$ standard-version --release-as 4.1.0  --prerelease beta  --dry-run
√ bumping version in package.json from 4.0.0 to null
√ outputting changes to CHANGELOG.md

---

---

√ committing package.json and CHANGELOG.md
√ tagging release v4.0.0
i Run `git push --follow-tags origin master` to publish
kf6kjg added a commit to kf6kjg/standard-version that referenced this issue Jun 1, 2021
@kf6kjg
fix: Combining both release-as and prerelease now doesn't break package
dc34a9c 
Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null.

This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case.

With this combination the user can override the version, the purpose of `release-as`, while still starting or continuing a pre-release, the purpose of of the `prerelease`.

Fixes conventional-changelog#542
@kf6kjg kf6kjg linked a pull request Jun 1, 2021 that will close this issue
Open
@TimothyJones TimothyJones mentioned this issue May 25, 2022
Merged
@gr00nd gr00nd mentioned this issue Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@wwh0219