fix(lib): getting .git from parent dir

[standy]

Closes #72

[codecov-io]

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #74   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         123    126    +3     
=====================================
+ Hits          123    126    +3

Impacted Files	Coverage Δ
lib/getGitFolder.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a579a3d...f683599. Read the comment docs.

[kentcdodds]

LGTM

[kentcdodds]

Let's use code instead of bug

[spirosikmd]

Thank you for the fix! I see you added a new package, but yarn.lock hasn't been committed? Can you update it? Or am I missing something?

[standy]

find-parent-dir was already in yarn.lock, since husky from devDependencies uses it.
https://github.com/kentcdodds/validate-commit-msg/blob/master/yarn.lock#L1097

I wonder why library has lockfile, isnt it ignored by package users? Looks like just yet another file to maintain

[spirosikmd]

Ah cool! Didn't notice that! But it is not ignored for development? Every contributor should have the same packages, right?

[standy]

Having same packages for every contributor does not guarantee that package will work for users, I think that having some diversity would be better for contributors
I know it might be some risks from having different versions inside dependencies, but since lockfile has same risks but for for users, we should rely on semver (and avoid package who do not)