Fix dependent evars line with defined evars #18991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how much we care about this feature but as long as it's an easy fix we may as well. Fix coq#18980
SkySkimmer
added
kind: fix
coqbot-app
bot
removed
the
request: full CI
|
I've been convinced for a while that this feature is an explicit breakage of invariants of the proof engine. Since the fix is local I agree with @SkySkimmer that it's fine to merge it, but future changes to the engine (e.g. a proper GC for the evar map) will likely break it again, and for good. I'd advise the maintainers of the UI relying on this to seriously start thinking about another approach. |
ppedrot
approved these changes
May 2, 2024
|
@coqbot merge now |
SkySkimmer
added a commit
that referenced
this pull request
May 6, 2024
coqbot-app
bot
moved this from Request 8.19.2 inclusion
to Shipped in 8.19.2
in Coq 8.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how much we care about this feature but as long as it's an easy fix we may as well.
Fix #18980