Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coredns/helm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: coredns-1.28.0
Choose a base ref
...
head repository: coredns/helm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: coredns-1.28.1
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 2, 2023

  1. Added ability to override defaultMode for extra secrets and bumped ve… 

    …rsion.

Signed-off-by: JT-IT <38433978+JT-IT@users.noreply.github.com>
    @JT-IT
    JT-IT committed Nov 2, 2023
    Copy the full SHA
    1a54304 View commit details

  2. Merge pull request #148 from JT-IT/allow-defaultmode-override 

    Ability to override defaultMode for extraSecrets
    @hagaibarel
    hagaibarel authored Nov 2, 2023
    Copy the full SHA
    61164fb View commit details
Showing with 5 additions and 3 deletions.
  1. +2 −2 charts/coredns/Chart.yaml
  2. +1 −1 charts/coredns/templates/deployment.yaml
  3. +2 −0 charts/coredns/values.yaml
4 changes: 2 additions & 2 deletions charts/coredns/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.28.0
version: 1.28.1
appVersion: 1.11.1
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -21,4 +21,4 @@ type: application
annotations:
artifacthub.io/changes: |
- kind: added
description: topologySpreadConstraints can be templated values
description: Added option to override defaultMode for extraSecrets
2 changes: 1 addition & 1 deletion charts/coredns/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -153,7 +153,7 @@ spec:
- name: {{ .name }}
secret:
secretName: {{ .name }}
defaultMode: 400
defaultMode: {{ default 400 .defaultMode }}
{{- end }}
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | indent 8 }}
2 changes: 2 additions & 0 deletions charts/coredns/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -246,8 +246,10 @@ extraVolumeMounts: []
extraSecrets: []
# - name: etcd-client-certs
# mountPath: /etc/coredns/tls/etcd
# defaultMode: 420
# - name: some-fancy-secret
# mountPath: /etc/wherever
# defaultMode: 440

# To support legacy deployments using CoreDNS with the "k8s-app: kube-dns" label selectors.
# See https://github.com/coredns/helm/blob/master/charts/coredns/README.md#adopting-existing-coredns-resources