Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDTokenVerifier from Provider #335

Closed
mitar opened this issue May 10, 2022 · 2 comments · Fixed by #336
Closed

IDTokenVerifier from Provider #335

mitar opened this issue May 10, 2022 · 2 comments · Fixed by #336

Comments

@mitar
Copy link
Contributor

mitar commented May 10, 2022

Provider.Verifier's documentation currently states:

The returned IDTokenVerifier is tied to the Provider's context and its behavior is undefined once the Provider's context is canceled.

Looking at the code I do not see this to be true. There is no context being passed from Provider to IDTokenVerifier. There is no context even saved into Provider. The only context is inside RemoteKeySet but even that one explicitly creates a new/cloned context using context.Background().

I think this line should be removed from documentation.

@ericchiang
Copy link
Collaborator

I think those are a hold over from the old logic :)

Feel free to send a PR

mitar added a commit to mitar/go-oidc that referenced this issue May 10, 2022
@mitar
Copy link
Contributor Author

mitar commented May 10, 2022

Done: #336

lukaszraczylo pushed a commit to lukaszraczylo/go-oidc that referenced this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants