Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-jose to fix CVE-2024-28180 #417

Closed
bcandeias opened this issue Mar 19, 2024 · 3 comments · Fixed by #421
Closed

Upgrade go-jose to fix CVE-2024-28180 #417

bcandeias opened this issue Mar 19, 2024 · 3 comments · Fixed by #421

Comments

@bcandeias
Copy link

Two weeks ago github.com/go-jose/go-jose released v.4.0.1 to fix a published vulnerability (CVE-2024-28180.

This is issue is to bump the dependency from v3.0.1 to v4.0.1.

(I can do a pull request with the bump)

bcandeias pushed a commit to bcandeias/go-oidc that referenced this issue Mar 19, 2024
This bumps the go-jose dependency to a version that addresses
vulnerability CVE-2024-28180.

Closes coreos#417
@bcandeias
Copy link
Author

I just realised that the API also changes, which likely means a go-oidc v4 as well.

The big difference is that jose.ParseSigned now requires the SignatureAlgorithm.

# github.com/coreos/go-oidc/v3/oidc
oidc/jwks.go:28:31: not enough arguments in call to jose.ParseSigned
	have (string)
	want (string, []jose.SignatureAlgorithm)

Trying to figure out what should we do here as it really doesn't make sense from an API perspective to request this when the string JWT has that encoded.

@ericchiang
Copy link
Collaborator

go-oidc intentional doesn't export anything that references its
JWT package, so it's fine to change the dependency without releasing a major version bump. We did that in the past when go-jose changed it's import path.

I can take a crack at updating. If I'm reading the new signature right this might actually fix #356 as well

Regardless, the CVE is for JWE implementation issues which this package doesn't use. v3.0.3 also appears to have the fix.

@bcandeias
Copy link
Author

bcandeias commented Mar 19, 2024

Regardless, the CVE is for JWE implementation issues which this package doesn't use. v3.0.3 also appears to have the fix.

Fair point. I didn't validate whether it was being used or not, and I was also being misled by the v4.0.1 release notes. #418 does the bump, but I tried to take a stab at using 4.0.1 (the one where the API changes). In interest of enabling #356 I can try contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants