Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store binaries in version control system (isohdpfx.bin) #24

Open
hadrien-toma opened this issue Jul 21, 2020 · 2 comments
Open

Comments

@hadrien-toma
Copy link
Contributor

What I want

  • I would like to not have a binary (isohdpfx.bin) in version control system
  • I would like to be able to fetch the required binaries on the fly, according to the context (version to fetch for instance)
  • If the official binary isohdpfx.bin does not fit my needs, I would like to be able to rebuild it myself in order to be able to control the involved changes made to it

Why I want

  • Having a binary in a repository always makes us wondering if this binary is malicious, so moving this part in a clean way to show what we do and how we do is a good way to proof the code innocence and good faith to dear users
  • I would like to enhance quality and to improve users adoption of the awesome work done in this repository

Question(s)

  • Do you think it is reasonable/achievable to externalize the fetch of this binary?
@dentarg
Copy link

dentarg commented Jul 21, 2020

I think #14 + my comment there is a nice solution for this, what do you think?

@hadrien-toma hadrien-toma changed the title Get binary from official place (isohdpfx.bin) Do not store binaries in version control system (isohdpfx.bin) Jul 21, 2020
@hadrien-toma
Copy link
Contributor Author

Yes @dentarg, you are totally right. I will not close this issue as it highlight the security concern but as soon as #14 is merged, it will be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants