Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do about test 933161-4 #3693

Open
theseion opened this issue May 5, 2024 · 2 comments
Open

Decide what to do about test 933161-4 #3693

theseion opened this issue May 5, 2024 · 2 comments
Labels
🧹 cleanup House cleaning

Comments

@theseion
Copy link
Contributor

theseion commented May 5, 2024

As described by @M4tteoP in #3273 (comment), checking for dl might not be worth the trouble. We still have a commented test though (933161-4) and we should decide whether we want to implement the check or drop the test.

@theseion theseion added the 🧹 cleanup House cleaning label May 5, 2024
@dune73
Copy link
Member

dune73 commented May 8, 2024

Is this playing into the "random base64 strings leading to FP" discussion? If yes, then probably not worth the trouble.

Do we understand the "web content" mentioned by @M4tteoP by now?

@theseion
Copy link
Contributor Author

theseion commented May 9, 2024

933161 looks for a function name followed by a comment. I would say that looks specific enough. It's not fool proof of course, but I don't think that base64 is an especially big issue in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 cleanup House cleaning
Projects
None yet
Development

No branches or pull requests

2 participants