-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpbin does not reflect requests perfectly #198
Comments
The httpbin go port (go-httpbin) is behaving in a better way:
Around Coraza we are already using it in some places as the backend to test the CRS, moving to it should be pretty smooth |
Great! I'll take a look. |
theseion
added a commit
to theseion/coreruleset
that referenced
this issue
Jan 7, 2024
httpbin does not properly reflect Unicode sequences but returns JSON Unicode escape sequences instead. This can break response tests that rely on the data in the response to be an exact copy of the request data. See coreruleset/go-ftw#198. This PR switches the backend for tests from httpbin to the go-httpbin port, as the port behaves correctly.
theseion
added a commit
to theseion/coreruleset
that referenced
this issue
Jan 7, 2024
httpbin does not properly reflect Unicode sequences but returns JSON Unicode escape sequences instead. This can break response tests that rely on the data in the response to be an exact copy of the request data. See coreruleset/go-ftw#198. This PR switches the backend for tests from httpbin to the go-httpbin port, as the port behaves correctly.
coreruleset/coreruleset#3464 fixes the issue for the CRS test suite but is not a generic solution for go-ftw. |
theseion
added a commit
to coreruleset/coreruleset
that referenced
this issue
Jan 8, 2024
httpbin does not properly reflect Unicode sequences but returns JSON Unicode escape sequences instead. This can break response tests that rely on the data in the response to be an exact copy of the request data. See coreruleset/go-ftw#198. This PR switches the backend for tests from httpbin to the go-httpbin port, as the port behaves correctly.
We now have albedo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
httpbin usually returns the request data in the response exactly as sent. At least in case of Unicode that is not true, unfortunately. Example:
The Unicode sequence is returned as a backslash escape sequence instead. That is semantically correct but bad for testing. We need to find a way around this.
The text was updated successfully, but these errors were encountered: