Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to standard interfaces #38

Closed
1 of 2 tasks
fzipi opened this issue Aug 28, 2021 · 3 comments
Closed
1 of 2 tasks

Move to standard interfaces #38

fzipi opened this issue Aug 28, 2021 · 3 comments
Assignees
@fzipi
Labels
enhancement New feature or request

Comments

@fzipi
Copy link
Member

fzipi commented Aug 28, 2021 •
edited

Initial implementation specifically went around standard interfaces like Client or RoundTripper.

Now that the project is working properly, we should revisit using standard interfaces to enable extensions from other users.

  • Use net/http#Client in http/client.go
  • Review RoundTripper and move round trip times there
@fzipi fzipi added the enhancement New feature or request label Aug 28, 2021
@fzipi
Copy link
Member Author

fzipi commented Mar 5, 2022

Moved http to ftwhttp to simplify interfaces naming in the future.

@fzipi fzipi self-assigned this Dec 11, 2022
@theseion
Copy link
Collaborator

theseion commented Jun 5, 2024

I think we can close this. @fzipi?

@fzipi
Copy link
Member Author

fzipi commented Jun 5, 2024

We can and we should.

@fzipi fzipi closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzipi fzipi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theseion @fzipi