Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature?]: pnpm leaves files in nodejs install dir, breaking nvm install #1093

Open
avelican opened this issue Jan 18, 2024 · 1 comment
Labels

Comments

@avelican
Copy link

avelican commented Jan 18, 2024

Description of the new feature / enhancement

Not sure if this is a bug or feature, but I had trouble installing nvm despite uninstalling npm because I forgot I had pnpm installed too, and it left a bunch of crap in C:\Program Files\nodejs folder. So the symlink failed and I was perplexed by nvm use not doing anything...

Suggestion: update readme to mention pnpm?

Suggestion: installer should warn about this? (nodejs existing causing symlink to fail)

Anyway, manually deleting nodejs install folder fixed this.
(That's probably not how you should uninstall pnpm, but that's a problem for future me...)

Scenario when this would be used?

Upon installing, so the install actually works...

Supporting information

No response

@coreybutler coreybutler added help wanted consider for rt Pinned for use in the rt project labels Jan 19, 2024
@coreybutler
Copy link
Owner

Well that is perplexing. Thank you for bringing it to my attention. I'm not sure if this is something we want to tackle in NVM4W, based on the premise that supporting a non-official package manager sets a precedent for supporting them all. I agree that a warning would be nice, but this might need to be something that's a part of the debug feature. I'll give it some thought.

That said, we did put together a plan for some degree of support around different package managers in Runtime, so that is likely where this will ultimately be resolved. I'll keep this issue open and mark it with help wanted to keep the discussion going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants