Adding 404 page on edit route #7727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aryanshu919 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Aryanshu919 clear the merge conflict |
|
@nihal467 Done. Could you review it? |
rithviknishad
requested changes
Apr 30, 2024
| @@ -100,7 +100,7 @@ const TextFormField = forwardRef((props: TextFormFieldProps, ref) => { | |||
| ); | |||
| const _trailing = | |||
| trailing === trailingFocused ? ( | |||
| <div className="absolute inset-y-0 right-0 flex items-center pr-3"> | |||
| <div className="relative inset-y-0 right-0 flex items-center pr-3"> | |||
There was a problem hiding this comment.
Why was this changed? Unrelated to the issue being solved right?
Feel free to create a separate issue if this solves an issue 😄
Comment on lines
+26
to
+28
| "/facility/:facilityId/patient/:patientId/consultation/:id/edit": () => ( | ||
| <Error404 /> | ||
| ), |
There was a problem hiding this comment.
The intention of the issue is, that any invalid links should show a 404 page, not just /edit.
This can be achieved by having a fallback to Error404 component if none of the URLs has matched with the current URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Redirecting the user to an existing 404 page whenever user go on "/edit" route.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist