Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all OP number validation #7751

Open
2 tasks
rithviknishad opened this issue May 2, 2024 · 3 comments · May be fixed by coronasafe/care#2147
Open
2 tasks

Remove all OP number validation #7751

rithviknishad opened this issue May 2, 2024 · 3 comments · May be fixed by coronasafe/care#2147
Assignees
Labels
Backend P1 breaking issue or vital feature urgent

Comments

@rithviknishad
Copy link
Member

rithviknishad commented May 2, 2024

Is your feature request related to a problem? Please describe.
When a patient is readmitted to the same facility and both the consultation (new and previous) are Out-patient consultations (decision after consultation), the OP number may be the same as the last consultation's OP number. However, currently it throws an error

Describe the solution you'd like

  • Need not perform a unique validation check for OP consultations if the previous consultation's facility is the same as the new consultation's facility.
  • If the previous consultation's facility is the same as the new consultation's facility, maybe we could auto-fill the OP Number field with the last consultation's OP No.? (To be discussed and finalized and NOT a priority, can be done separately)

Additional context
image

cc: @nihal467 @aparnacoronasafe

@rithviknishad rithviknishad added Backend P1 breaking issue or vital feature labels May 2, 2024
Copy link

github-actions bot commented May 2, 2024

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@skks1212 skks1212 self-assigned this May 8, 2024
@skks1212 skks1212 linked a pull request May 12, 2024 that will close this issue
4 tasks
@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented May 22, 2024

The requirement here is to remove any type of Data validation on the OP No. field. Irrespective of the facility the patient is admitted to.

Discussed with @gigincg

CC: @rithviknishad @skks1212 @nihal467

REASON: The issue is, some hospitals are utilising this field to add their Patient ID (MRD No) for the patient, which may be consistent across all encounters for the patient in the facility. This is an acceptable behaviour. In order to allow this, remove all data validation from the field

@nihal467 nihal467 changed the title OP number not to be unique if readmitted to same facility Remove all OP number validation May 28, 2024
@sainak
Copy link
Member

sainak commented May 28, 2024

The requirement here is to remove any type of Data validation on the OP No. field. Irrespective of the facility the patient is admitted to.

Discussed with @gigincg

CC: @rithviknishad @skks1212 @nihal467

REASON: The issue is, some hospitals are utilising this field to add their Patient ID (MRD No) for the patient, which may be consistent across all encounters for the patient in the facility. This is an acceptable behaviour. In order to allow this, remove all data validation from the field

@aparnacoronasafe the field is handling many responsibilities, should we consider splitting it up?

cc: @gigincg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants