Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stop using deprecated grpc/naming package #2785

Closed
bboreham opened this issue Jun 24, 2020 · 10 comments
Closed

Update to stop using deprecated grpc/naming package #2785

bboreham opened this issue Jun 24, 2020 · 10 comments
Labels
stale type/chore Something that needs to be done; not a bug or a feature

Comments

@bboreham
Copy link
Contributor

It is gone from the latest gRPC release 1.30.

I found a notice announcing this: grpc/grpc-go#3180

Also interesting: why didn't the deprecated package raise a lint warning?

@bboreham bboreham added the type/chore Something that needs to be done; not a bug or a feature label Jun 24, 2020
@nicolai86
Copy link
Contributor

nicolai86 commented Jun 26, 2020

I'd like to pick this up. Any objections?

Following the discussion in grpc/grpc#12295, the proposed fix seems to switch to a server side managed connection approach using MaxConnectionAge and MaxConnectionAgeGrace, which will force clients to re-connect defined by MaxConnectionAgeGrace.

As I understand the query frontend code this would break how frontends fan-out query processing to workers today. @bboreham is that a fair statement?

If we want to stick to using polling we have to write our own dns watcher (or pull in the deleted code), or we adjust the interaction between the query frontend and the worker.

@stale
Copy link

stale bot commented Aug 25, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 25, 2020
@pracucci
Copy link
Contributor

Still valid. Required by future upgrade to gRPC 1.3.0.

@stale stale bot removed the stale label Aug 26, 2020
@stale
Copy link

stale bot commented Oct 25, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 25, 2020
@jtlisi
Copy link
Contributor

jtlisi commented Oct 25, 2020

still valid

@stale stale bot removed the stale label Oct 25, 2020
@stale
Copy link

stale bot commented Dec 24, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 24, 2020
@pracucci
Copy link
Contributor

Still valid

@stale stale bot removed the stale label Dec 25, 2020
@jtlisi
Copy link
Contributor

jtlisi commented Feb 25, 2021

Unblocked now that etcd-io/etcd#12709 has been merged

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 2, 2021
@pracucci
Copy link
Contributor

pracucci commented Jun 3, 2021

We're not using the upstream grpc/naming  anymore but, due to convenience, we've imported some of its code in pkg/util/grpc/naming. I'm going to close this issue, given we don't have plans to get rid of it, but feel free to reopen it if you want to reconsider it.

@pracucci pracucci closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

No branches or pull requests

4 participants