Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active series to all user stats page #4972

Merged

Conversation

songjiayang
Copy link
Contributor

@songjiayang songjiayang commented Nov 17, 2022

Signed-off-by: songjiayang songjiayang1@gmail.com

What this PR does:

Add active_series to all_user_stats page.

Which issue(s) this PR fixes:
Fixes #4917

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 17, 2022
Signed-off-by: songjiayang <songjiayang1@gmail.com>
songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 17, 2022
Signed-off-by: songjiayang <songjiayang1@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 17, 2022
@alanprot
Copy link
Member

NIce!! :D

Can you fix the lint?

songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 19, 2022
Signed-off-by: songjiayang <songjiayang1@gmail.com>
@songjiayang
Copy link
Contributor Author

Thank @alanprot, I have changed protoc-gen-gogoslick version from v1.3.2 to v1.3.0 on my local, code generated looks fine. review again please.

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/distributor/distributor.go Show resolved Hide resolved
Signed-off-by: songjiayang <songjiayang1@gmail.com>
Copy link
Collaborator

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks great.

@alvinlin123 alvinlin123 merged commit de25e5b into cortexproject:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add active series metric to ingester stats page
4 participants