Log query params in query frontend when error #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
log-params-error
branch
from
352d22f
to
71f7ee2
Compare
wenxu1024
reviewed
Nov 28, 2022
alanprot
approved these changes
Nov 29, 2022
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
log-params-error
branch
from
694000c
to
d57b85c
Compare
|
Since it is a simple change on logging only, I will merge on green. |
t00350320
pushed a commit
to t00350320/cortex
that referenced
this pull request
Nov 29, 2022
* log query params in query frontend when error Signed-off-by: Ben Ye <benye@amazon.com> * log errors Signed-off-by: Ben Ye <benye@amazon.com> * change log level when error Signed-off-by: Ben Ye <benye@amazon.com> * fix lint Signed-off-by: Ben Ye <benye@amazon.com> * update changelog Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye benye@amazon.com
What this PR does:
Right now if a query fails at query frontend, no query parameters will be logged so we don't have any visibility about what's the failed query and why it failed.
This pr always log query params to make sure we catch them.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]