-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to enable TSDB memorry snapshot on shutdown #5011
Add a flag to enable TSDB memorry snapshot on shutdown #5011
Conversation
9a9d626
to
978215a
Compare
dc073d5
to
2b28bd9
Compare
2b28bd9
to
46136f4
Compare
46136f4
to
df1fb7c
Compare
@alanprot @friedrichg Please share your thoughts about this change. Should we make it a global configuration or a per tenant configuration? The criteria of when should we make a config per tenant is somewhat not very clear to me. But since some other TSDB configurations are also global so this one is probably fine to be global, too. |
df1fb7c
to
6203538
Compare
Signed-off-by: wangguoliang <iamwgliang@gmail.com>
6203538
to
da52a1f
Compare
The pr has been updated, are there any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and addressing the feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Signed-off-by: wangguoliang iamwgliang@gmail.com
What this PR does:
Add a flag to enable TSDB memorry snapshot on shutdown.
FYI:https://ganeshvernekar.com/blog/prometheus-tsdb-snapshot-on-shutdown/#faster-restarts
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]