Let blocks_cleaner delete blocks concurrently #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgliang
force-pushed
the
enhancement/delete-blocks-by-blocks_cleaner-concurrently
branch
3 times, most recently
from
db57caa
to
3ef1731
Compare
|
PS: In fact, for parameters like this, I think the default value is enough. Exposing this parameter will only increase the burden. |
+1... lets try to keep the config simple |
Yes. If most people agree, I will remove the parameter control, the default value is 16. |
yeya24
reviewed
Dec 9, 2022
wgliang
force-pushed
the
enhancement/delete-blocks-by-blocks_cleaner-concurrently
branch
2 times, most recently
from
7643fe1
to
e51fc41
Compare
alanprot
approved these changes
Dec 13, 2022
alanprot
reviewed
Dec 15, 2022
Signed-off-by: wangguoliang <iamwgliang@gmail.com>
wgliang
force-pushed
the
enhancement/delete-blocks-by-blocks_cleaner-concurrently
branch
from
e51fc41
to
0a69b1c
Compare
|
@yeya24 is it ready to be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangguoliang iamwgliang@gmail.com
What this PR does:
Let blocks_cleaner delete blocks concurrently. And it can make blocks cleanup faster when there is large amount of blocks.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]