Logging Vertical Sharding info on query stats #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
changed the title
alanprot
force-pushed
the
log-sharding-stats
branch
from
712b0c2
to
986b156
Compare
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
log-sharding-stats
branch
from
986b156
to
e29e02a
Compare
yeya24
reviewed
Dec 13, 2022
Signed-off-by: Alan Protasio <approtas@amazon.com>
alanprot
force-pushed
the
log-sharding-stats
branch
from
a212306
to
6fd94fb
Compare
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* logging sharding stats Signed-off-by: Alan Protasio <approtas@amazon.com> * test Signed-off-by: Alan Protasio <approtas@amazon.com> * improving tests Signed-off-by: Alan Protasio <approtas@amazon.com> * changelog Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alan Protasio <approtas@amazon.com> Signed-off-by: Alex Le <leqiyue@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alan Protasio approtas@amazon.com
What this PR does:
Adding the sharding info in the query stats log as following:
This PR will also allow other middlewares to add info if needed like how the query was split by day or cache hit informations.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]